Convert allow to expect #402
Conversation
|
Start on Issue #300 |
| @@ -370,7 +370,7 @@ pub(crate) mod serialized_request { | |||
| use serde::Deserializer; | |||
| use serde::Serializer; | |||
|
|
|||
| #[allow(clippy::borrowed_box)] // required by serde | |||
| #[expect(clippy::borrowed_box, reason = "Required by serde")] | |||
There was a problem hiding this comment.
nit: unless there's a strong existing convention in the community to capitalize, I'd default to keeping these reason strings lowercase
| @@ -18,7 +18,7 @@ pub struct Options { | |||
| } | |||
|
|
|||
| impl Options { | |||
| #[allow(clippy::expect_fun_call)] | |||
| #[expect(clippy::expect_fun_call)] | |||
There was a problem hiding this comment.
I can't tell if this is even needed? I guess that's precisely what switching to expect will help us catch, ha. Lets see what CI comes back with...
|
Thanks for taking a crack at this! We'd love to see this land, though by the looks of it, there's still quite a few iterations left to go before all the lints get ironed out here. We'll try to be reasonably timely with releasing CI runs here, but if we're lagging behind, you may want to look at the CI runner logs and figure out which |
|
Resolved review comments - have clippy working for linux / macos builds fully now with (think I was probably missing some targets / features prerviously), but don't have windows test for the same locally |
|
I believe you should be able to clippy lint the windows build by specifying a custom target, and also ensuring that vars like |
|
Going to close this for now then (as if I do get access to windows box, will need to push onto branch to sync so no point reopening until there is something finished) - apologies for opening too hastily! |
|
No worries - thanks for taking a crack at it! |
Start on converting allow to expect - avoided codegen / macros as in some cases makes sense (eg lint fires off in some code generated and not others), and avoided some lints such as Missing_Docs, where expect would say the lint is not needed but no allow resulted in the lint triggering